Skip to content

Fix extension option when used with custom plugins list #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2015
Merged

Fix extension option when used with custom plugins list #34

merged 1 commit into from
Sep 11, 2015

Conversation

sapegin
Copy link
Contributor

@sapegin sapegin commented Sep 11, 2015

Didn’t notice a return statement yesterday. So when you specify the use option custom extensions don’t apply.

@mightyaleksey
Copy link
Member

Yeah, the use option breaks plugin options, like createImportedName and generateScopedName. So I use return to quit function earlier when you don't need to set plugins manually.

It's good that you noticed it :) Thanks

mightyaleksey added a commit that referenced this pull request Sep 11, 2015
@mightyaleksey
Merge pull request #34 from sapegin/fixextensions
ae66fb1 
Fix extension option when used with custom plugins list
@mightyaleksey mightyaleksey merged commit ae66fb1 into css-modules:master Sep 11, 2015
@mightyaleksey
Copy link
Member

published 1.0.7

@pekim pekim mentioned this pull request Sep 27, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sapegin @mightyaleksey